search

nodegui / svelte-nodegui

Build performant, native and cross-platform desktop applications with native Svelte + powerful CSS-like styling.🚀
https://svelte.nodegui.org/
MIT License
2.84k stars 55 forks source link

Adds <svg> element with React NodeGUI interface #59

Closed LukeyBeachBoy closed 3 years ago

LukeyBeachBoy commented 3 years ago

@shirakaba I followed your advice from our previous discussion and came up with this! I initially had some troubles testing this because I hadn't bulit a library from src and used it in a project before.

But now I see it works as expected: image

shirakaba commented 3 years ago

I've just checked out your PR and it works great!

image

I've tried it as "svg" myself and it seems safe, so let's go with that rather than "qtsvg" after all (sorry for the fuss). I'll be happy to merge it once you've applied those changes; if you're comfortable with squashing the commits and rebasing onto main again, that would be perfect, too.

shirakaba commented 3 years ago

Merged into the main branch and published in v0.1.1!

@all-contributors please add @LukeyBeachBoy for code

allcontributors[bot] commented 3 years ago

@shirakaba

I've put up a pull request to add @LukeyBeachBoy! :tada:

LukeyBeachBoy commented 3 years ago

Thanks for finishing this up for me @shirakaba! I was unable to get back to it this week but I'm glad we were able to keep it as !