nodejs / Release

Node.js Release Working Group
4.04k stars 577 forks source link

Grant release team maintainer access to release-related tooling #557

Open BethGriggs opened 4 years ago

BethGriggs commented 4 years ago

547 opened further questions about the structure of the Release WG. It has been discussed that release team should have some responsibility over release related tooling.

richardlau commented 4 years ago

FWIW There's a shadow @nodejs/citgm-admins team that is used to control edit access to the CITGM CI jobs. We can probably keep the name of that group as-is.

MylesBorins commented 4 years ago

+1

On Thu, Mar 26, 2020 at 1:15 PM Richard Lau notifications@github.com wrote:

FWIW There's a shadow @nodejs/citgm-admins https://github.com/orgs/nodejs/teams/citgm-admins team that is used to control edit access to the CITGM CI jobs. We can probably keep the name of that group as-is.

— You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub https://github.com/nodejs/Release/issues/557#issuecomment-604557403, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADZYV4YXLDGX6DW2KSMWVTRJOESXANCNFSM4LUMUBEA .

gdams commented 4 years ago

+1

mhdawson commented 4 years ago

+1

joyeecheung commented 4 years ago

+1

joyeecheung commented 4 years ago

BTW I opened https://github.com/nodejs/admin/issues/488

MylesBorins commented 2 years ago

If we don't want to move forward with this work we should probably close this issue

richardlau commented 2 years ago
  • [ ] Grant release-automation write access to release related tooling
    • [ ] changelog-maker
    • [ ] branch-diff
    • [ ] node-core-utils

The last few times this issue has come up in Release WG meetings the consensus has been to add @nodejs/releasers to these repositories rather than creating a new team or repurposing the citgm team.

richardlau commented 2 years ago

Opened

BethGriggs commented 2 years ago

This was discussed in https://github.com/nodejs/Release/issues/735. We no longer plan to rename the CITGM team. Instead, this issue can be closed once the releaser have been granted maintainer access to the mentioned repositories. I've updated the issue description accordingly.

richardlau commented 2 years ago

Opened

Given no objections and a 👍 I've added the releasers team to https://github.com/nodejs/branch-diff and https://github.com/nodejs/changelog-maker.

richardlau commented 2 years ago

Opened https://github.com/nodejs/node-core-utils/issues/628 for node-core-utils.

richardlau commented 2 years ago

Based on https://github.com/nodejs/citgm/pull/901#issuecomment-1118513519 I've added citgm to the list. I'll open an issue for it in the citgm repository.

bengl commented 2 years ago

Should https://github.com/nodejs/commit-stream be added to this list of repos?

BethGriggs commented 2 years ago

Should https://github.com/nodejs/commit-stream be added to this list of repos?

Added commit-stream to the list.