Closed kfarnung closed 6 years ago
@digitalinfinity @MSLaguana Please take a look at https://github.com/nodejs/node-chakracore/pull/583/commits/3e41263cc2b634b8989a41e3c9143f937b56bb26 https://github.com/nodejs/node-chakracore/pull/583/commits/e7c7eafabc4b2739bff2535e5f4afc9e88180c22
EDIT: I used BeyondCompare to diff the Win32 and WOA definitions. I think since there are no changes in the diff which mention WIN32 or revert WOA, I think it's fine.
I took a look, nothing seemed particularly crazy so if it builds then LGTM
Merged upstream tag v10.9.0 into v10.x
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes