nodejs / node-chakracore

Node.js on ChakraCore :sparkles::turtle::rocket::sparkles:
Other
1.92k stars 342 forks source link

Wire up `resourceNameToUrl` support in inspector #598

Closed kfarnung closed 5 years ago

kfarnung commented 5 years ago

With the landing of https://github.com/nodejs/node/pull/22251, the output for the script URL has changed and the tests are now failing. I'm going to skip them for now and re-enable them once the support has been added.

not ok 2126 sequential/test-inspector
  ---
  duration_ms: 0.614
  severity: fail
  exitcode: 1
  stack: |-
    [test] Testing /json
    [err] Debugger listening on ws://127.0.0.1:22381/3fd1bc71-8650-49c4-8248-41e82c76946c
    [err] For help, see: https://nodejs.org/en/docs/inspector
    [err] 
    [test] Testing /json/list
    [test] Testing /json/version
    [test] Testing /json/activate
    [test] Testing /json/activate/boom
    [test] Testing /json/badpath
    [test] Connecting to a child Node process
    [test] Testing /json/list
    [test] Verifying debugger stops on start (--inspect-brk option)
    [err] Debugger attached.
    [err] 
    { AssertionError [ERR_ASSERTION]: E:\GitHub\node-chakracore5\test\fixtures\loop.js !== file:///E:/GitHub/node-chakracore5/test/fixtures/loop.js
       at InspectorSession.prototype._isBreakOnLineNotification (E:\GitHub\node-chakracore5\test\common\inspector-helper.js:251:7)
       at Anonymous function (E:\GitHub\node-chakracore5\test\common\inspector-helper.js:263:11)
       at InspectorSession.prototype._asyncWaitForNotification (E:\GitHub\node-chakracore5\test\common\inspector-helper.js:242:14)
       at Generator.prototype.next (native code:0:0)
       at _tickCallback (internal/process/next_tick.js:68:7)
      generatedMessage: false,
      name: 'AssertionError [ERR_ASSERTION]',
      code: 'ERR_ASSERTION',
      actual: 'E:\\GitHub\\node-chakracore5\\test\\fixtures\\loop.js',
      expected: 'file:///E:/GitHub/node-chakracore5/test/fixtures/loop.js',
      operator: 'strictEqual' }
    1
  …
not ok 2131 sequential/test-inspector-debug-brk-flag
  ---
  duration_ms: 0.754
  severity: fail
  exitcode: 1
  stack: |-
    [test] Connecting to a child Node process
    [test] Testing /json/list
    [err] Debugger listening on ws://127.0.0.1:9229/7042f73c-c2bf-4cc1-9a72-0d3b5bc8a4dd
    [err] For help, see: https://nodejs.org/en/docs/inspector
    [err] 
    [err] Debugger attached.
    [err] 
    [err] (node:4932) [DEP0062] DeprecationWarning: `node --inspect --debug-brk` is deprecated. Please use `node --inspect-brk` instead.
    [err] 
    { AssertionError [ERR_ASSERTION]: E:\GitHub\node-chakracore5\test\fixtures\loop.js !== file:///E:/GitHub/node-chakracore5/test/fixtures/loop.js
       at InspectorSession.prototype._isBreakOnLineNotification (E:\GitHub\node-chakracore5\test\common\inspector-helper.js:251:7)
       at Anonymous function (E:\GitHub\node-chakracore5\test\common\inspector-helper.js:263:11)
       at InspectorSession.prototype._asyncWaitForNotification (E:\GitHub\node-chakracore5\test\common\inspector-helper.js:242:14)
       at Generator.prototype.next (native code:0:0)
       at _tickCallback (internal/process/next_tick.js:68:7)
      generatedMessage: false,
      name: 'AssertionError [ERR_ASSERTION]',
      code: 'ERR_ASSERTION',
      actual: 'E:\\GitHub\\node-chakracore5\\test\\fixtures\\loop.js',
      expected: 'file:///E:/GitHub/node-chakracore5/test/fixtures/loop.js',
      operator: 'strictEqual' }
    1
  …
not ok 2134 sequential/test-inspector-exception
  ---
  duration_ms: 0.533
  severity: fail
  exitcode: 1
  stack: |-
    [test] Connecting to a child Node process
    [test] Testing /json/list
    [err] Debugger listening on ws://127.0.0.1:22442/e914c7f1-57f2-4104-ab0f-dba5604ec6f5
    [err] For help, see: https://nodejs.org/en/docs/inspector
    [err] 
    [test] Verifying debugger stops on start (--inspect-brk option)
    [err] Debugger attached.
    [err] 
    { AssertionError [ERR_ASSERTION]: E:\GitHub\node-chakracore5\test\fixtures\throws_error.js !== file:///E:/GitHub/node-chakracore5/test/fixtures/throws_error.js
       at InspectorSession.prototype._isBreakOnLineNotification (E:\GitHub\node-chakracore5\test\common\inspector-helper.js:251:7)
       at Anonymous function (E:\GitHub\node-chakracore5\test\common\inspector-helper.js:263:11)
       at InspectorSession.prototype._asyncWaitForNotification (E:\GitHub\node-chakracore5\test\common\inspector-helper.js:242:14)
       at Generator.prototype.next (native code:0:0)
       at _tickCallback (internal/process/next_tick.js:68:7)
      generatedMessage: false,
      name: 'AssertionError [ERR_ASSERTION]',
      code: 'ERR_ASSERTION',
      actual:
       'E:\\GitHub\\node-chakracore5\\test\\fixtures\\throws_error.js',
      expected:
       'file:///E:/GitHub/node-chakracore5/test/fixtures/throws_error.js',
      operator: 'strictEqual' }
    1
  …
not ok 2143 sequential/test-inspector-resource-name-to-url
  ---
  duration_ms: 0.314
  severity: fail
  exitcode: 1
  stack: |-

    E:\GitHub\node-chakracore5\test\common\index.js:701
    const crashOnUnhandledRejection = (err) => { throw err; };
                                                 ^
    [object Object]
  …