search

nodejs / node-chakracore

Node.js on ChakraCore :sparkles::turtle::rocket::sparkles:
Other
1.92k stars 342 forks source link

fix --v8-options not working #613

Closed chopdown closed 5 years ago

chopdown commented 5 years ago

https://github.com/nodejs/node-chakracore/issues/612

Checklist
kfarnung commented 5 years ago

@boingoing Please take a look when you have a moment.

kfarnung commented 5 years ago

@chopdown Thanks for patching this!

boingoing commented 5 years ago

Looks good to me, thanks for the fix.

boingoing commented 5 years ago

Landed in d5bf883acfcf21b436e17018cd19555decad0597

boingoing commented 5 years ago

Thanks again for the fix, it should be included in the next node-chakracore release.