nodejs / node

Node.js JavaScript runtime ✨🐢🚀✨
https://nodejs.org
Other
108.03k stars 29.82k forks source link

test-crypto-secure-heap fails on IBM i #36929

Open richardlau opened 3 years ago

richardlau commented 3 years ago

This test was newly added earlier in the week by 03c056401f23fe83ab6f16741759182e95a407bd and has been intermittently failing on IBM i (the CI for which is only run on the daily CI run) since.

richardlau commented 3 years ago

cc @nodejs/platform-ibmi

ThePrez commented 3 years ago

Can you please assign this to @dmabupt and me? This might be due to some differences in the openssl build between the IBM distribution and the CI, since the IBM distribution uses the system-provided openssl that may have IBM patches. I haven't done debug/investigation, just a hunch.

richardlau commented 3 years ago

Can you please assign this to @dmabupt and me?

I've assigned to you. I can't seem to assign to @dmabupt, probably because he's not in the nodejs org (that will happen as part of https://github.com/nodejs/node/issues/36569).

jasnell commented 3 years ago

Would be good to go ahead and open a PR marking it flaky on that platform (if you haven't done so already :-) ...)

targos commented 3 years ago

probably because he's not in the nodejs org

I think it's possible to assign external people after they commented on the thread.

richardlau commented 3 years ago

Would be good to go ahead and open a PR marking it flaky on that platform (if you haven't done so already :-) ...)

Opened https://github.com/nodejs/node/pull/36986.