Closed anonrig closed 7 months ago
+1 to this, code blocks IMO should always be nowrap, and just allow the user to scroll if needed.
@MattIPv4 feeling like drafting a PR? 👀
Can we also do something about the squashed tab elements from the screenshot? I looks not mobile friendly in a mobile friendly design. It might require some design changes.
Can we also do something about the squashed tab elements from the screenshot? I looks not mobile friendly in a mobile friendly design. It might require some design changes.
I don't know how we could address that. Show less snippets on mobile?
Make it horizontally scrollable too?
Make it horizontally scrollable too?
Could you elaborate? 🤔
Something like this:
Reference: https://saadiam.medium.com/tabs-design-best-practices-8fafe936606f
The different number of rows wrapped in the tabs make it look clunky and also too little do interact, code needs to have a defined line size and only break after that, and making it scroll when overflows. I think the best option is to make both tabs and code scrollable(tabs would not wrap line).
The different number of rows wrapped in the tabs make it look clunky and also too little do interact, code needs to have a defined line size and only break after that, and making it scroll when overflows. I think the best option is to make both tabs and code scrollable(tabs would not wrap line).
I assume this is an issue only on mobile. And extremely small screens. I doubt people will copy these snippets from their phone's because... Well, what's the point? They cannot try and test those snippets from there.
But we could anyhow support scrolling for small viewports. But the code wrapping is intentional for large screens.
I assume this is an issue only on mobile. And extremely small screens. I doubt people will copy these snippets from their phone's because... Well, what's the point? They cannot try and test those snippets from there.
I disagree, I sometimes do some programming on my phone when I wanna test something, I run in either remote env or local virtual Linux
e, I sometimes do some programming on my phone when I wanna test something, I run in either remote env or local virtual Linux
Well, there's no science behind this, it boils down to personal opinions. But as mentioned before, more than happy to have this being changed on mobile; On desktop we intent to keep the break points.
https://github.com/nodejs/nodejs.org/assets/110736557/baacbc03-ba33-4b7b-ba1a-0ff9e42922e8
Whenever the nav bar is clicked on, the page size gets increased
This is unrelated to this specific issue, would you mind opening a new one? :)
This is unrelated to this specific issue, would you mind opening a new one? :)
Ah sorryy, I mistook this as the general feedback thread, my bad
This is unrelated to this specific issue, would you mind opening a new one? :)
Ah sorryy, I mistook this as the general feedback thread, my bad
All good :)
Renamed the title to avoid future confusion and better search for duplicates
<?xml version="1.0" encoding="UTF-8"?>
Idea: instead of wrapping text on mobile on homepage on code examples, let user scroll horizontally