search

nodejs / postject

Easily inject arbitrary read-only resources into executable formats (Mach-O, PE, ELF) and use it at runtime.
Other
187 stars 14 forks source link

What to use for CI #62

Open RaisinTen opened 2 years ago

RaisinTen commented 2 years ago

Postject was using CircleCI under the Postman account and it got disconnected after the repo got transferred to the nodejs org. Now that CI doesn't work anymore, it's time to reconsider what we should use for CI:

@nodejs/single-executable wdyt?

jviotti commented 2 years ago

One of the eventual goals of Postject is the support AIX's XCOFF. Given that, it'd be cool if we can use a CI system that supports AIX. How does Node.js core do it? If there is AIX under Jenkins, is there any chance we could reuse that?

Otherwise, the simplest approach is probably GitHub Actions?

mhdawson commented 2 years ago

Since this is under the Node.js org I suggest we use Node.js' Jenkins CI.

That is where we ensure we can test on all Node.js supported platform/versions. I can help set up a jenkins job. Ideally it would be as easy as clone this repo, then run make test or some equivalent, although I know it is often more complicated than that.

mhdawson commented 2 years ago

And to answer @jviotti, yes we have instances of all supported platforms including AIX :)

jviotti commented 2 years ago

Sounds exciting!

RaisinTen commented 2 years ago

I can help set up a jenkins job.

Thanks, that sounds great! We would need a way to run https://github.com/nodejs/postject/blob/0d7aab19f2472f159c08802e67bfb4d64611ca1d/.circleci/config.yml on Jenkins.

jviotti commented 2 years ago

@RaisinTen Jenkins won't be able to run the CircleCI config, of course. We would need to get rid of that .circleci folder, refactor these steps into i.e. shell scripts, and then configure Jenkins to run them instead.

RaisinTen commented 1 year ago

@tony-go and I spent some time today to come up with a jenkins pipeline to unblock postject's development: https://github.com/nodejs/build/pull/3114