search

nodejs / unofficial-builds

Unofficial binaries for Node.js
https://unofficial-builds.nodejs.org
221 stars 46 forks source link

update link to loong64 toolchain #117

Open shipujin opened 4 months ago

shipujin commented 4 months ago

update link to loong64 toolchain

rvagg commented 4 months ago

is this going to cause compatibility headaches for anyone using this when it bumps across all release lines? should we be branching on release line for this upgrade or are you confident that all users of these binaries are going to be happy with this bump?

shipujin commented 4 months ago

is this going to cause compatibility headaches for anyone using this when it bumps across all release lines?

After I verified the update toolchain in the local docker, the compilation and running were successful, Didn't seem to find anything unusual.

should we be branching on release line for this upgrade

Well, in that case, what do I need to do? Can you guide me, thanks

or are you confident that all users of these binaries are going to be happy with this bump?

It seems that the update of the toolchain, adding new features to LoongArch, is a good thing to update the toolchain.

Best regards

rvagg commented 4 months ago

@shipujin what I'm asking is - are binaries produced with this toolchain going to be problematic for people who have assumptions based around the previous toolchain. A bit like the issues that people have with glibc linking. If this is simply a compiler upgrade and the product is going to be roughly the same, but maybe better, then that's fine, best not overcomplicate the build process. My concern is about incompatibilities and I'm looking to you for guidance on that, or maybe some research if you don't know the answer?

shipujin commented 4 months ago

@shipujin what I'm asking is - are binaries produced with this toolchain going to be problematic for people who have assumptions based around the previous toolchain. A bit like the issues that people have with glibc linking. If this is simply a compiler upgrade and the product is going to be roughly the same, but maybe better, then that's fine, best not overcomplicate the build process. My concern is about incompatibilities and I'm looking to you for guidance on that, or maybe some research if you don't know the answer?

ok, I understand what you mean. I will investigate what functions have been updated in the toolchain upgrade and then discuss with you, thanks

Best regards