search

nodesource / docker-node

Dockerfiles for building docker images with the NodeSource Node.js binaries baked in.
MIT License
192 stars 22 forks source link

Add support for Ubuntu 16.04 LTS - Xenial Xerus #54

Closed billinghamj closed 8 years ago

billinghamj commented 8 years ago

Also worth nothing that vivid has reached EOL - perhaps should be removed

billinghamj commented 8 years ago

I have also not been able to run dante on my Mac. The Docker stuff doesn't seem to like it.

retrohacker commented 8 years ago

Hey @billinghamj! Thank you so much for opening this!

Taking a look now.

Re: dante. It is just a puppet master sitting on top of the docker cli tool. Are you getting any weird errors out of it?

retrohacker commented 8 years ago

I've been merging these changes into the work I was doing with automation stuff. It is on the production build server now. A few of the tests are failing, fixing those now. Should have xenial (and a few other distros) shipped soon!

Thanks for your help here!

billinghamj commented 8 years ago

No worries - appreciate it.

I installed the Docker for Mac GUI, but it just seemed to keep crashing. I am using macOS Sierra though so that is quite likely to be the issue.

retrohacker commented 8 years ago

This landed in https://github.com/nodesource/docker-node/commit/f708bfe6ab1c88704b8ab7ee0e41f7daca6c7335