search

nodesource / ncm-ci

NCM for CICD systems
https://nodesource.com/products/certified-modules
MIT License
8 stars 2 forks source link

allow ncm2-api / accounts URLs to be overridable #11

Closed pmuellr closed 6 years ago

pmuellr commented 6 years ago

There should be a way we can test ncm-ci against staging and maybe dev environments. Dev environments are a bit iffy, but may be do-able. I'm thinking env var.

We tried overriding the hard-coded prod url for ncm2-api in the script, which works for the first graphQL request, but the analyze-tree thingee seemed to be hardcoded to use prod.

juliangruber commented 6 years ago

The graphql package supports process.env.NCMAPI_URL for overriding the default api path, which is the only way ncm-analyze-tree connects to our apis. ncm-ci@6.1.0 no also supports this option.