search

nolanlawson / emoji-mart-outside-react

Demo of how to use emoji-mart outside of React
https://nolanlawson.github.io/emoji-mart-outside-react/
8 stars 5 forks source link

Remove prop-types #8

Closed rugk closed 5 years ago

rugk commented 5 years ago

Is https://github.com/missive/emoji-mart#removing-prop-types already followed here?

If not, it would likely be better to follow it to remove that lib there.

rugk commented 5 years ago

As we do not use babel here, however, @nolanlawson, how could we remove it?

nolanlawson commented 5 years ago

You would need babel, yes.

nolanlawson commented 5 years ago

I didn't want to overcomplicate this guide by adding production-level optimizations (e.g. that's also why I didn't do any minification), but if you want to see how to remove prop-types, please see: https://github.com/nolanlawson/pinafore/blob/861c7dbe1e51694ba59662eab52a3e4bd742077a/webpack/client.config.js#L38-L57

rugk commented 5 years ago

Hmm, this still uses this babel loader…