Bundle cjs and esm - Githubissues

nomcopter / react-mosaic

A React tiling window manager

https://nomcopter.github.io/react-mosaic/

Other

4.39k stars 226 forks source link

Bundle cjs and esm #214

Open Lonli-Lokli opened 6 months ago

Lonli-Lokli commented 6 months ago

Fixes #193

Changes proposed in this pull request: Bundle both cjs and esm making a few changes as possible.

Reviewers should focus on: Confirming the new bundle works in both cjs and esm projects.

Lonli-Lokli commented 2 months ago

In order to make thigs work with both Node and browser I have to add tsup. Also it was too difficult to update and make mocha+chai work with new module so test framework has been changed to vitest.

Additionally lodash deps has been changed to ESM dependency and updated imports to make it work in ESM

Lonli-Lokli commented 2 months ago

Also I had to disable tslint because it was complaining (prettier) about both CR/CRLF. It was again non-fixable in reasonable time. Can you consider migrating to eslint and run prettier on commit ?