nonamecrackers2 / simple-clouds

Rendering mod that overhauls Minecraft's clouds and weather
Other
32 stars 6 forks source link

[Bug]: (SERVER to CLIENT with Serene Season) Client Crash when Server Season is in Mid Spring #78

Open VirtualGaming1 opened 1 week ago

VirtualGaming1 commented 1 week ago

Guidelines

Minecraft Version

1.21.1

Mod Version

0.6.3

Mod Loader

Forge

Mod Loader Version

47.3.12

Graphics Card

AMD Radeon RX 6950 XT

Drivers Version

24.10.1 (10/11/2024)

Describe the Bug

So I just had this issue and it is between Server to Client with Serene Season (9.1.0.0) and as soon I did a command /Season Set mid_Spring client crash but server stay running and all that the server reported is the DC. I did try reconnecting to the server and crash on load and still dose the same when restarted the server. I was able to fix it after I put the command /Season Set early_spring

NOTE: I did disable shaders and switch the cloud setting from shaded to default and still crash

Steps to Reproduce

  1. have a Dedicated server (or Game server) and load up the Client
  2. Connect to server and make sure you are Op on the server
  3. do "/season set mid_spring" | This is were the client side crash happen
  4. After Crash restart the game and try to rejoin the server | and the world load crash happen on Client side
  5. restart server and repeat step 4

Crash Reports/Logs

crash-2024-11-09_17.40.40-client.txt

Screenhots

No response

Mod List

is in the crash report at the bottom

VirtualGaming1 commented 1 week ago

Had the same crash just now and I think this is due to with Secondary season (DRY or WET) as this effects like desert or jungle not having rain coming down in dry season which send a null value to client. This is my main guess

BarelyAPrincess commented 1 week ago

I'm so glad I found this because I'm experiencing the exact same crash, but when checking Serene Seasons, I discovered it happened in the late spring season. I also have seeming noticed it happening in a Mediterranean Forest, but not some others, which should be one of the biomes from Biomes O' Plenty.

Lexal1 commented 1 week ago

hello! adding on to this, the logs say java.lang.IllegalArgumentException: Cannot be NONE precipitation type. this probably has to do with the dry season trying to cancel rain, but simpleclouds doesn't understand it so it crashes. that's just my uneducated guess though

BarelyAPrincess commented 1 week ago

It most certainly would seem this bug is related to something Serene Seasons is doing wrong. I guess from around line 253 of the WorldEffects class that it's giving the elution of rain, but the type is obviously NONE. Since this error is causing a lot of issues for my personal game, and there is little telling what the actual underlying problem is. I think I might make a temporary patch for my game for now, but I hope an official fix comes soon.