noobaa / noobaa-core

High-performance S3 application gateway to any backend - file / s3-compatible / multi-clouds / caching / replication ...
https://www.noobaa.io
Apache License 2.0
273 stars 80 forks source link

Cloud resources usage is counted twice on retries #3840

Open dannyzaken opened 7 years ago

dannyzaken commented 7 years ago

Environment info

Actual behavior

  1. when adding delegation of cloud read\writes to object io we removed the HeadObject that checks for overwrites of blocks and take it into account in the usage calculations.
  2. since cloud resource only writes unique blocks on every write, the only way overwrites can occur are retries after failures\timeouts

Expected behavior

  1. we should handle retries correctly and not count usage again

Steps to reproduce

  1. somehow cause object_io to retry write_block

Screenshots or Logs or other output that would be helpful

(If large, please upload as attachment)

nimrod-becker commented 6 years ago

Danny Issues

github-actions[bot] commented 1 month ago

This issue had no activity for too long - it will now be labeled stale. Update it to prevent it from getting closed.