nordtheme / atom-ui

An arctic, north-bluish clean and elegant minimal Atom UI theme.
https://www.nordtheme.com/ports/atom-ui
MIT License
95 stars 15 forks source link

Atom 1.13 Shadow DOM removal #49

Closed arcticicestudio closed 7 years ago

arcticicestudio commented 7 years ago

Starting from Atom version 1.13, the contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. This means the :host and ::shadow pseudo-selectors and the /deep/ combinator selector should be completely removed. To prevent breakage with existing style sheets, Atom will automatically upgrade selectors for versions less or equal to 1.12.

Currently Atom 1.13 is in the beta chanel (1.13.0.beta6). This issue prepares the package for the incoming breaking changes when Atom 1.13 reaches the stable channel. It will me merged as soon as the official Atom theme One Dark Syntax updates the Atom engine requirement to >=1.13.

The flight manual provides the great migration guide "Removing Shadow DOM styles" for package authors to prepare their packages for this breaking change.

There are also reference pull requests for the Atom Core theme packages One Dark Syntax and One Dark UI.

The associated improvement/ghi-#49-atom-1.13-shadow-dom-removal branch will be merged as soon as the versions of the official themes "One Dark UI" and "One Dark Syntax" are bumped to <=1.13 in their package.json files to keep compability as long as lower versions are supported.

Tasks

Known issues/bugs

arcticicestudio commented 7 years ago

🚢 Shipped in apm package release version 🏷 0.10.0. This also closes #51.

/cc @YogliB