Full-Width tabs disabled

[peteringram0]

When the full-width tabs are disabled the close button is on-top of the file type icon.

[arcticicestudio]

Thanks for your report 👍 I tried to reproduce this but it seems like there are differences in the setup. I am running Atom 1.14.3 on Arch Linux (GNOME DE) with the file-icons package version 2.0.17 and my icon for the settings-view is different as you can see on the screenshot.

Can you please post some setup information like

• the version of Atom
• a list of all your installed packages including the version to see if there are conflicts
• the OS you're running
  • if it is not Windows please add information about your distro
• your Atom config or at least the config of your icon package (if there is one)

so I can try to reproduce it?

[peteringram0]

I had the seti-icons package enabled which was causing part of the issue. With it disabled it still looks like there is an issue:

Atom version: 1.14.4 Packages: [stylus, atom-beautify, atom-bootstrap3, atom-jade, atom-typescript, dotblocker, editorconfig, emmet, file-icons (2.0.17), fold-functions, pigments] OSX 10.12.3

"*":
  "atom-beautify":
    general:
      _analyticsUserId: "59b34174-1565-4602-a67e-9f89ddecde22"
  core:
    disabledPackages: [
      "goto-definition"
      "language-elm"
      "language-elmx"
      "linter"
    ]
    telemetryConsent: "no"
    themes: [
      "nord-atom-ui"
      "one-dark-syntax"
    ]
  editor:
    fontSize: 12
    preferredLineLength: 100
    showIndentGuide: true
    tabLength: 4
  "exception-reporting":
    userId: "e94c6348-7cc9-b2b6-df64-88867be0175f"
  minimap:
    absoluteMode: true
  "nord-atom-ui":
    compactView: true
    fileIcons: false
    tabSizing: false
  "one-light-ui":
    layoutMode: "Compact"
  welcome:
    showOnStartup: false

[arcticicestudio]

Thanks, I've tested this on macOS. I forgot that I've implemented this selector to move the close icon on tabs to the left when running on macOS. This can be fixed by setting padding-left: 10px for the icon. Following the conversations in atom/tabs #378 and atom/one-dark-ui #179, this should be better moved into a optional theme setting to not mess with people's muscle memory. Maybe this will be implemented into the core 📦 atom/tabs sometime.

Anyway, I'll try to fix it this weekend and merge it into the next version.

[arcticicestudio]

I played around with the tab sizing rules and I'll just remove the platform-specific selector for now because a theme setting would cause more bugs. It will be reimplemented after a whole refactoring of the UI scaling code (#58) or when this feature gets implemented into the core tabs package.

[peteringram0]

When will this be merged in plz? Thanks 👍

[arcticicestudio]

I'll do it this evening when I'm back home 😄

[arcticicestudio]

Before with file-icons package

Before with seti-icons package

After with file-icons package

After with seti-icons package

[arcticicestudio]

🚢 Shipped in apm package release version 🏷 0.10.2

/cc @peteringram0

[peteringram0]

Thanks, works like a charm :)