search

nordtheme / emacs

An arctic, north-bluish clean and elegant Emacs theme.
https://www.nordtheme.com/ports/emacs
MIT License
492 stars 63 forks source link

Use `display-color-cells` to enable 24-bit color terminal support #64

Closed visigoth closed 4 years ago

visigoth commented 6 years ago

This change enables the use of nord-theme with emacs' new 24-bit color terminal support.

christopherraa commented 5 years ago

I see this PR has been here for a while. Are there someone with write access here that could do a review? It would be nice to see if this PR solves #64 as well.

rien333 commented 4 years ago

I see this PR has been here for a while. Are there someone with write access here that could do a review? It would be nice to see if this PR solves #64 as well.

@arcticicestudio I've been using this for about year now. More so, I even need to use this fix, given https://github.com/arcticicestudio/nord-emacs/issues/59.

arcticicestudio commented 4 years ago

Sorry for the enormous delays, but "real life" keeps me busy almost ~18h a day 😟 Like described in https://github.com/arcticicestudio/nord-emacs/issues/59#issuecomment-447625096, I heavily rely on the community for this port project since I'm not a Emacs user and I resist to learn the language of syntactically arranged brace characters (Lisp) 😝

Anyway, I promise to review, reproduce and test this PR no later than Saturday afternoon. I've seen a lot of forks of this repository only for this fix and many users approved the problems was resolved using the changes from this PR so I guess it'll work the way it should without breaking any other users setup.

arcticicestudio commented 4 years ago

@visigoth I can also go ahead and rebase your PR on develop and remove both unrelated code blocks if you like, just let me know so we can get this finally merged :smile:

arcticicestudio commented 4 years ago

Since the source branch of this PR is not a feature branch but the default branch visigoth/nord-emacs@develop there's no way for me to update the required PR changes. I'll create a new branch based on this PR and open a new PR to superseed this one.

arcticicestudio commented 4 years ago

Superseded by #88.