search

norlab-ulaval / libpointmatcher

An Iterative Closest Point (ICP) library for 2D and 3D mapping in Robotics
BSD 3-Clause "New" or "Revised" License
1.59k stars 544 forks source link

Libpointmatcher segfaults with latest libnabo changes #228

Closed bochen87 closed 6 years ago

bochen87 commented 6 years ago

See details at https://github.com/ethz-asl/libnabo/issues/81

Summary: Probably segfaults due to libnabo now returning -1 instead of 0 for an invalid index here: https://github.com/ethz-asl/libpointmatcher/blob/75044815d40ff934fe0bb7e05ed8bbf18c06493b/pointmatcher/OutlierFiltersImpl.cpp#L253

HannesSommer commented 6 years ago

Thanks for "moving" here.

Actually the invalid index is NNS::InvalidIndex (-1 for signed indices) : https://github.com/ethz-asl/libnabo/blob/master/nabo/nabo.h#L343.

I'll try to propose a fix.

bochen87 commented 6 years ago

fixed with #230