search

nostrband / nostr-login

MIT License
44 stars 5 forks source link

Unable to approve permission request when widget is blocked by pop-up window #125

Open leafes opened 4 days ago

leafes commented 4 days ago

Precondition: your account shouldn't have permissions to post reactions on selected website

  1. Login on the published website through nsec.app (ex. https://leafes47.npub.pro/)
  2. Try to post reaction using actions menu Image

expected: pop-up window with permission request is open actual: permission request is sent, but need to open nsec.app manualy to allow requested permissions

UPD: Now i see there is a request on the login module but its impossible to press while reaction select and postiong reaction pop-up is present (it's blurred and unavaliable to click). So when user try to post reaction he will face endless load on the reaction post.

leafes commented 4 days ago

@bekbolsun22 We should either rework the login widget or adjust the pop-up blur so that it doesn’t blur the widget

nostrband commented 4 days ago

This should actually be an issue with nostr-login - we wan't nostr-login to be a universal library, which means it has to work somehow even with a dialog opened by the app.

a-fralou commented 2 days ago

Due to the way the dialog works, we can't simply open our own dialog on top of the dialog, as this will block clicks on the document.

We need to learn to detect an already open dialogue and open your own on top of it.

leafes commented 2 days ago

@a-fralou, is it possible to trigger a pop-up browser window for a signature request without the user clicking a button in the widget? If so, what problems could this potentially cause?