nostrver-se / nostr-php

PHP helper library for Nostr https://nostr-php.dev
https://nostr-php.dev
MIT License
50 stars 15 forks source link

Run test suite on each push to GH #36

Closed 1ma closed 11 months ago

1ma commented 11 months ago

Simple GitHub action that clones the project, installs the dependencies and runs the test suite. It tests each supported version of PHP in parallel.

Setting up a code coverage badge is possible but a bit trickier than in GitLab. It involves either generating the badge as an SVG file on each run of the pipeline and committing it to the repo automatically (a bit ugly IMO), or uploading the coverage information to a third party service. Here you can see an example of the latter option:

https://github.com/1ma/jimmy#programming-bitcoin https://scrutinizer-ci.com/g/1ma/jimmy/code-structure/master/code-coverage/src/

I can set that up if you want, too. For now I've left it out because of the introduction of a 3rd party dependency.

Sebastix commented 11 months ago

Thanks!

Let's make an issue for that to discusss it further. Maybe it's better to add a code sniffer first with phpcs.