search

notablackbear / poe_qolV2

52 stars 34 forks source link

Upon refresh, filter file isn't modified but rather replaced #80

Open daman4567 opened 3 years ago

daman4567 commented 3 years ago

The filter file is getting wholesale replaced with just the chaos recipe section when you try to refresh it from the changes.

daman4567 commented 3 years ago

I've found where this happens, directly before searching for the placement of the chaos recipe section, the start and end points of the expected section are set to encompass the whole filter file. If the chaos recipe section isn't there then it never changes those variables and replaces the whole file upon refresh. For some reason, this happened to me with the included filter file a few times and then inexplicably it started working correctly. Setting both variables to 0 instead of setting them to 0 and the end of the file should fix this. If you also include the start and end markers in the chaos recipe section that gets written in, this can effectively make a filter compatible without any modification required.

daman4567 commented 3 years ago

The debug message on line 654 is also never written to the log file because it's improperly indented, which puts it right after an unconditional break.