search

notadamking / Stock-Trading-Environment

A custom OpenAI gym environment for simulating stock trades on historical price data.
MIT License
801 stars 296 forks source link

action_type claimed to be discrete but is a BOX #7

Open ppanteliadis opened 4 years ago

ppanteliadis commented 4 years ago

If you are claiming a Discrete action space, I would expect something like 

if action_type == 1: #BUY
elif action_type ==2: #SELL
else: # HOLD

Why the action_type is a float? I'm new in to gym environments. so maybe this is more of a question https://github.com/notadamking/Stock-Trading-Environment/blob/e72167bb4e134fc998f11c2f9d14ae9d882431ce/env/StockTradingEnv.py#L70

596227421 commented 2 years ago

If you are claiming a Discrete action space, I would expect something like

if action_type == 1: #BUY
elif action_type ==2: #SELL
else: # HOLD

Why the action_type is a float? I'm new in to gym environments. so maybe this is more of a question

https://github.com/notadamking/Stock-Trading-Environment/blob/e72167bb4e134fc998f11c2f9d14ae9d882431ce/env/StockTradingEnv.py#L70

如果您要声明一个离散动作空间，我会期望类似

if action_type == 1: #BUY
elif action_type ==2: #SELL
else: # HOLD

为什么 action_type 是浮点数？我是健身房环境的新手。所以也许这更像是一个问题

https://github.com/notadamking/Stock-Trading-Environment/blob/e72167bb4e134fc998f11c2f9d14ae9d882431ce/env/StockTradingEnv.py#L70 action_type == 0：#BUY action_type == 1：#SELL action_type == 2：#HOLD