search

notaryproject / notation-go

A collection of libraries for supporting sign and verify OCI artifacts. Based on Notary Project specifications.
Apache License 2.0
39 stars 42 forks source link

update: removed Sign with OCI artifact manifest #308

Closed Two-Hearts closed 1 year ago

Two-Hearts commented 1 year ago

This PR removes notation-go Sign's support of OCI artifact manifest as it is removed from image-spec v1.0.0-rc.3. In other words, Notation will only generate signatures stored as OCI image manifest in the future. (Note: Notation can still consume signatures already stored as OCI artifact manifest for backwards compatibility.)

Related issue: https://github.com/notaryproject/notation/issues/660

codecov-commenter commented 1 year ago

Codecov Report

Merging #308 (80ec48f) into main (06d04cc) will not change coverage. The diff coverage is 16.66%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #308   +/-   ##
=======================================
  Coverage   74.39%   74.39%           
=======================================
  Files          23       23           
  Lines        2175     2175           
=======================================
  Hits         1618     1618           
  Misses        439      439           
  Partials      118      118
Impacted Files Coverage Δ
registry/repository.go 49.35% <16.66%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more