notion-enhancer / notion-repackaged

notion executables with the notion-enhancer embedded & a vanilla port of the official app to linux
https://notion-enhancer.github.io/getting-started/installation
MIT License
908 stars 52 forks source link

Extract: Error writing to file Uninstall Notion Enhanced.exe | Windows #84

Closed Nek-12 closed 2 years ago

Nek-12 commented 2 years ago

What is happening?
The installation script throws an error and shuts down, leaving the installation incomplete. Extract: Error writing to file Uninstall Notion Enhanced.exe
Checking the installation directory during / after the installation reveals that no such file is present in the folder.

What should be happening? Notion installs successfully

Screenshots (if applicable): image

Operating system/browser name & version: Edition Windows 11 Home Version 21H2 Installed on ‎11-‎Sep-‎21 OS build 22000.376 Experience Windows Feature Experience Pack 1000.22000.376.0 System type 64-bit operating system, x64-based processor

notion-enhancer and/or notion-repackaged version: 2.0.18-1 Setup notion-enhancer configuration (enabled/disabled mods and their settings): N/A

dragonwocky commented 2 years ago

I'm on the same build Windows, installing the same .exe, and it's working fine. Nobody else has reported this problem- is it possible that there are some file conflicts (e.g. the previous version of the app not being properly removed first) or some permissions problems on your side?

Nek-12 commented 2 years ago

The issue was caused by lack of storage space on target drive. You may decide to #wontfix this issue or add a proper message and/or free space check to the installer

dragonwocky commented 2 years ago

I don't think this is something controlled by the notion-enhancer, our installer is created by https://github.com/electron-userland/electron-builder - it may be better to open a bug report there? @jamezrin will know better than me, though.

jamezrin commented 2 years ago

I have seen another issue in electron-builder which was dismissed for the same reason, lack of storage space, so yeah there is not much to do.