notionparallax / ShadowWolf

A mini ERP type app to capture people, projects and their relationships.
GNU General Public License v2.0
1 stars 6 forks source link

Pictures on Project Sheets out of order #775

Closed hinds89 closed 9 years ago

hinds89 commented 9 years ago

@Dawil @DanielMok The project sheets aren't always selecting the pictures based on ranking of 10, 9 ,8 For example see (ones that have pdfs as images?):

Dawil commented 9 years ago

This is most likely due to the images_by_tag function in oaf/app/models.rb. At first I thought the call to .reverse was unnecessary but now that I look at it tag_rank || 0 could also be problematic.

Either way this should be a pretty straightforward case of writing some failing unit tests then passing them.

hinds89 commented 9 years ago

@Dawil I'm still having an issue with ASB North Wharf S0910004

hinds89 commented 9 years ago

It works now (I need to learn to click the mouse)