search

notlmn / rollup-plugin-transform-tagged-template

Apply transformations on static contents of tagged template string literals
https://npmjs.com/package/rollup-plugin-transform-tagged-template
MIT License
5 stars 4 forks source link

esm imports of babel not working #8

Open thejustinwalsh opened 2 years ago

thejustinwalsh commented 2 years ago

I could not get this plugin to work in Vite / rollup 3 without making the following changes:

https://github.com/notlmn/rollup-plugin-transform-tagged-template/compare/master...thejustinwalsh:rollup-plugin-transform-tagged-template:fix-esm-babel-imports

I can open a PR, but I am unsure if there is a better solution here. The problem seems to stem from the way node.js handles imports of commonjs modules from esm modules and may have been updated in node > 15? I am using node 16 (lts) and the changes within that branch appear to be neccessary.

notlmn commented 2 years ago

Yes, please. Try sending a PR out with updated dependencies as well. Always welcome :)

jaa134 commented 1 year ago

@notlmn @thejustinwalsh Has there been any updates on this issue?

thejustinwalsh commented 1 year ago

@jaa

@notlmn @thejustinwalsh Has there been any updates on this issue?

I never got around to working up the PR. Feel free to take over where I left off!