search

notofonts / noto-cjk

Noto CJK fonts
http://www.google.com/get/noto/help/cjk
3k stars 215 forks source link

Inclusion of parent directory in release archive prevents extraction #216

Closed izahn closed 2 years ago

izahn commented 2 years ago

The release archive at https://github.com/googlefonts/noto-cjk/releases/download/Sans2.004/02_NotoSansCJK-TTF-VF.zip cannot be extracted using some common software. For example, using the Ark utility from KDE on Linux produces this error message:

Screenshot_20220319_120510

More problematically this issue prevents packaging noto-cjk for conda-forge, as discussed in https://github.com/conda-forge/staged-recipes/pull/16032. When trying to extract the archive we get an error saying

libarchive.exception.ArchiveError: Path contains '..' (errno=-1, retcode=-25, archive_p=94306351011216)

The full log may be available at https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=477574&view=logs&jobId=6f142865-96c3-535c-b7ea-873d86b887bd&j=6f142865-96c3-535c-b7ea-873d86b887bd&t=22b0682d-ab9e-55d7-9c79-49f3c3ba4823

Can you please release an archive without this issue? This will help us package noto-cjk for conda-forge.

punchcutter commented 2 years ago

I see what happened here. All zips are supposed to contain the LICENSE file from the root directory, but that doesn't work when also maintaining the directory structure of the specific subfolders. I replaced the zips in the current Sans2.004 release without making a new release. The only difference will be that the LICENSE file is now correctly included. That should fix the issue for you.

izahn commented 2 years ago

Confirm this is fixed, thank you for the quick response!