search

notofonts / noto-cjk

Noto CJK fonts
http://www.google.com/get/noto/help/cjk
2.94k stars 215 forks source link

Different directory structures in symmetric release assets: w/ or w/o junk directory names #262

Open muzimuzhi opened 9 months ago

muzimuzhi commented 9 months ago

Is your feature request related to a problem? Please describe.

Most Sans release assets are zipped using junk directory names (the zip flag -l), but their corresponding Serif release assets keep directories.

Taking language specific OTFs Japaneses for Sans and Serif as a pair of examples, https://github.com/notofonts/noto-cjk/blob/727f898acdf7b100d308af8edf63c3953b626a1b/gh-release-noto-cjk-sans.sh#L18 https://github.com/notofonts/noto-cjk/blob/727f898acdf7b100d308af8edf63c3953b626a1b/gh-release-noto-cjk-serif.sh#L18

$ unzip -l 06_NotoSansCJKjp.zip
Archive:  06_NotoSansCJKjp.zip
  Length      Date    Time    Name
---------  ---------- -----   ----
 17032620  04-30-2021 19:04   NotoSansCJKjp-Bold.otf
 17828280  04-30-2021 19:04   NotoSansCJKjp-Black.otf
 16467736  04-30-2021 19:04   NotoSansCJKjp-Regular.otf
 14927060  04-30-2021 19:04   NotoSansCJKjp-Thin.otf
 16554004  04-30-2021 19:04   NotoSansCJKjp-Medium.otf
 16360020  04-30-2021 19:04   NotoSansCJKjp-Light.otf
 16445132  04-30-2021 19:04   NotoSansCJKjp-DemiLight.otf
     4301  03-20-2022 10:36   LICENSE
---------                     -------
115619153                     8 files

$ unzip -l 07_NotoSerifCJKjp.zip
Archive:  07_NotoSerifCJKjp.zip
  Length      Date    Time    Name
---------  ---------- -----   ----
        0  08-15-2023 15:31   OTF/Japanese/
 24425344  08-17-2023 09:09   OTF/Japanese/NotoSerifCJKjp-Light.otf
 24724232  08-17-2023 09:09   OTF/Japanese/NotoSerifCJKjp-Medium.otf
 24635344  08-17-2023 09:09   OTF/Japanese/NotoSerifCJKjp-SemiBold.otf
 25456164  08-17-2023 09:09   OTF/Japanese/NotoSerifCJKjp-Bold.otf
 21327140  08-17-2023 09:09   OTF/Japanese/NotoSerifCJKjp-ExtraLight.otf
 24456012  08-17-2023 09:09   OTF/Japanese/NotoSerifCJKjp-Regular.otf
 24034448  08-17-2023 09:09   OTF/Japanese/NotoSerifCJKjp-Black.otf
     4301  08-17-2023 09:09   LICENSE
---------                     -------
169062985                     9 files

This difference was introduced since the first commit for release scripts, b4f6497749235331fdbfe349ae0c581185f5c28f.

Describe the solution you'd like

Ideally I prefer junk directory names, but improving consistency means introducing breaking changes, hence I'm not sure if any change should happen.