Closed yuvraj1107thapa closed 2 weeks ago
@yuvraj1107thapa is attempting to deploy a commit to the notsoocool's projects Team on Vercel.
A member of the Team first needs to authorize it.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
codecache | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Oct 26, 2024 0:06am |
Hi @yuvraj1107thapa,
I appreciate your contribution and the effort you put into this PR. However, before raising a PR, we have certain rules and a code of conduct that need to be followed. You should first be assigned to an issue, then proceed to raise a PR.
Kindly create an issue describing the changes, and once that's done, I will review the code and assign the appropriate labels.
Thanks for understanding!
@yuvraj1107thapa
@yuvraj1107thapa still its getting failed why deploying, kindly fix it
@yuvraj1107thapa if you didn't fix it by today itself, I will close your PR
@notsoocool Fixed all deployment issues and improved component stability. The code has been tested locally and is working as expected. It is ready for review.
Sorry for the delayed review, @yuvraj1107thapa. I was about to merge your PR, but I noticed an issue: when clicking "Add Snippets," it only gives a toast notification for "usage cannot be empty," even if all fields are empty. Ideally, it should validate each field in order, starting with the title and then moving to the others. Could you please address this?
@yuvraj1107thapa any updates??
This PR refactors the AddSnippet component to improve user experience and code maintainability.
Changes:
Impact:
Testing:
No breaking changes.