nottinghamtec / PyRIGS

📅 A Django-based event booking system designed for use by TEC PA and Lighting, a 'Student Run Service' of the University of Nottingham Students Union
https://nottinghamtec.co.uk/
Other
25 stars 8 forks source link

Reimplement rigboard page in a fully responsive manner #567

Closed FreneticScribbler closed 11 months ago

FreneticScribbler commented 1 year ago

(cherry picked from commit b3939d84264faf1d2559a0257485b70df4a08930)

Requires refinement. Opening in order to get a review app going.

FreneticScribbler commented 11 months ago

I think this is now good to go if you're happy for me to merge it @nickw29 ? It's not perfect, and I bet someone's got a device that sits in a weird screen size spot, but it's better than the current sidescroll table by a mile!

FreneticScribbler commented 11 months ago

And so continues (barely) the long standing tradition of RIGS development during NAT panto 😆

nickw29 commented 11 months ago

Screenshot_20231217-184605 Small issue on Chrome on android

FreneticScribbler commented 11 months ago

Works on my device! Maybe I'm the one with a weird screen size, lol.

How wide is your screen?

Sent from Proton Mail mobile

-------- Original Message -------- On 17 Dec 2023, 18:56, nickw29 wrote:

Screenshot_20231217-184605.png (view on web) Small issue on Chrome on android

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you modified the open/close state.Message ID: @.***>

nickw29 commented 11 months ago

I've gone back to a phone with a normal sized screen, 20:9 - 2400x1080 - 6.4"

Edit: Phone is a Pixel 6

jerbzz commented 11 months ago

FYI this is what it looks like on my iPhone 14 Pro Max (1284px × 2778px, 430px × 932px viewport, CSS Pixel Ratio of 3)

image

image

FreneticScribbler commented 11 months ago

Looks good to me on your iPhone Jerbs, until you turn it landscape and then all manner of layout horrors fall out :scream: No idea why the header isn't full width. The rigboard should end where the new button is, as well, it's somehow leaking out of the page layout. Gak.

Nick, I was gonna guess that you were the one person in the data I pulled that had a weirdly ultra old version of Chrome, but I'm not sure that's allowed in Google Pixel land? If I set my viewport to the size it theoretically is on your phone, it doesn't break, so I'm a little stumped honestly!

nickw29 commented 11 months ago

Yeah, my phone and browser are up to date. Mine also looks the same in landscape, maybe it's time for a forum poll

nickw29 commented 10 months ago

image This is an interesting look

FreneticScribbler commented 10 months ago

Oh dear...

Sent from Proton Mail mobile

-------- Original Message -------- On 21 Jan 2024, 19:21, nickw29 wrote:

image.png (view on web) This is an interesting look

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you modified the open/close state.Message ID: @.***>

FreneticScribbler commented 10 months ago

Should be fixed momentarily. Still can't reproduce any of the other problems on either Firefox or Brave (chromium based) :thinking: