notwaldorf / ama

:raising_hand: Ask @notwaldorf anything!
94 stars 13 forks source link

Broken links in chromium-101 blog post #75

Closed hassansalehe closed 6 years ago

hassansalehe commented 6 years ago

Hi Monica,

I was recently reading your illustrated guide about contributing to Chromium. Thank you for the well-written article. However, I did come across two dead links that I'm willing to fix if your blog is on Github -- I checked but could not locate. Below are details if you would like to fix them.

The first broken link is https://github.com/notwaldorf/.not-quite-dotfiles/blob/master/chrome which is used in this excerpt:

However, I’ll tell you about the custom things that I use that aren’t on that page, which I’m pretty proud of.

I investigated your ".not-quite-dotfiles" repo and it seems that you moved the "chrome" file to "zsh/chrome" in commit # 0b78b54. The correct link should be https://github.com/notwaldorf/.not-quite-dotfiles/blob/master/zsh/chrome

The second broken link is https://github.com/notwaldorf/not-quite-dotfiles/blob/master/chrome#L15 found in the bullet point:

I have a fancy set of aliases like make and go, so that I don’t have to remember about which flags I want to run Chrome with. They come in doskey variants on Windows

The correct link should be https://github.com/notwaldorf/.not-quite-dotfiles/blob/master/zsh/chrome#L15

Thank you.

notwaldorf commented 6 years ago

Oh! Thanks! I refactored that repo and totally forgot I mentioned it anywhere else. Fixed!