nova-video-player / aos-AVP

NOVA opeN sOurce Video plAyer: main repository to build them all
Apache License 2.0
3.17k stars 190 forks source link

Add proper SSA/ASS subtitles support #128

Open Vallimar opened 5 years ago

Vallimar commented 5 years ago

A lot of fansub anime shows use styled .ass subs, which nova player disregards and causes subtitles to be displayed incorrectly, or with multiple on-screen subs, not at all.

Would it be possible to present styled subs as-is? I would like to watch subtitled anime in Nova along with other things but it's not possible because of the re-formatting issues. Using external player is a workaround, but not a convenient one.

courville commented 3 years ago

Indeed ass subs support is really rudimentary (Video/src/main/java/com/archos/mediacenter/video/player/SubtitleManager.java SSA) and would deserve some improvements. Contributions welcome :-)

courville commented 2 years ago

@rahaaatul you are right, support for ssa/ass will require more work i.e. inclusion of libssa

mo-han commented 2 years ago

@courville ssa/ass full support is urgent, maybe one of the last two pieces to make NOVA perfect/complete (the other one is guesture playback control, which is not quite urgent) could we "borrow" some code from VLC, since VLC did pretty good in this (actually VLC does pretty job in many aspects, but still has some unacceptable bugs/cons)

ghost commented 2 years ago

@courville ssa/ass full support is urgent, maybe one of the last two pieces to make NOVA perfect/complete (the other one is guesture playback control, which is not quite urgent) could we "borrow" some code from VLC, since VLC did pretty good in this (actually VLC does pretty job in many aspects, but still has some unacceptable bugs/cons)

I second that. Nova is my favorite video app, however due to me watching a lot of content with ssa subtitles, I currently barely use it anymore.

MarcoRavich commented 2 years ago

@rahaaatul you are right, support for ssa/ass will require more work i.e. inclusion of libssa

Well, @mpv-android uses @libass too:

libass support for styled subtitles

Hope that helps/inspires !

rahaaatul commented 2 years ago

@courville Please, work on this. This feature is very important for many of us. Thank you.

courville commented 1 year ago

Some simple fixes prior to proper libass integration consideration: fix color tag https://github.com/nova-video-player/aos-Video/commit/587a229f8ee6e5e48220c79354d4f1a2e32e1bb7

sdugoten commented 1 year ago

just FYI, some ASS subtitles without styles will render the whole screen not readable, something like this

https://i.imgur.com/LTFvGjL.jpeg

Some times it can fill the whole screen with all these numbers

ghost commented 4 months ago

As an everyday Nova user I just want to bump this as it still is my most requested feature for your player.