search

nova-video-player / aos-AVP

NOVA opeN sOurce Video plAyer: main repository to build them all
Apache License 2.0
3.48k stars 201 forks source link

[Bug]: Can't select correct subtitles #607

Open markmov opened 2 years ago

markmov commented 2 years ago

In case an MKV file has multiple subtitles with the same language (e.g. CC subtitles and normal subtitles), the first subtitles are displayed even when the second subtitles are selected.

okan35 commented 2 years ago

I think if you could leave media info of that mkv file it will definitely help.

markmov commented 2 years ago

See info attached. Notice tracks 15 and 16. Both are Hebrew, and when selecting track 16, the player displays track 15.

Hit.and.Run.2021.S01E04.1080p.WEB.H264-EXPLOIT.txt

Pentaphon commented 2 years ago

@courville I think this issue applies to me as well. I'd like to have Nova autoselect English tracks titled "SDH" (means subtitles for deaf or hard of hearing, very common on blurays and streaming) for a hard of hearing English-speaking person.

@markmov seems to want to autoselect Hebrew tracks titled "Hebrew CC". CC is another term for the same thing, with has speaker identification, dialogue, sound effects, and music description for people who can't hear.

We need a way to autoselect tracks that are titled "SDH" or "CC" for people who are deaf or hard of hearing.

Perhaps an option that looks for subtitles that have "SDH" or "CC" in the subtitle track title in order to select the right track for deaf or hard of hearing people so they don't have to select it themselves each time?

Here's the mediainfo for an SDH subtitle track, very common in streaming services.

Text #2 ID : 4 Format : UTF-8 Codec ID : S_TEXT/UTF8 Codec ID/Info : UTF-8 Plain Text Duration : 27 min 53 s Bit rate : 68 b/s Count of elements : 494 Stream size : 14.0 KiB (0%) Title : SDH Language : English Default : No Forced : No

Here's the mediainfo for the regular English subtitle from the same file.

Text #1 ID : 3 Format : UTF-8 Codec ID : S_TEXT/UTF8 Codec ID/Info : UTF-8 Plain Text Duration : 25 min 36 s Bit rate : 52 b/s Count of elements : 306 Stream size : 9.85 KiB (0%) Language : English Default : No Forced : No