search

nova-video-player / aos-AVP

NOVA opeN sOurce Video plAyer: main repository to build them all
Apache License 2.0
3.38k stars 201 forks source link

[Bug]: Problem downloading subtitles #830

Closed scatolo closed 3 months ago

scatolo commented 1 year ago

Problem description

Hi, if I try to download the subtitles directly from the player it can find them in the language I need but after that I select the one I need but then it is not selectable because it has not been downloaded. I also entered the opensubtitles credentials but I didn't solve it.

Steps to reproduce the issue

Go to any content and try to download subtitles

Expected behavior

No response

Your phone/tablet/androidTV model

Oppo Reno 6 Pro

Operating system version

Android 13

Application version and app store

6.0.97 GitHub

Additional system information

No response

Debug logs

No response

baxax commented 1 year ago

It is a same problem on my machine -android tv box T95 Max+ "cant find subtitles" -but on OpenSubtitles websites subtitles are there... I'm talking about Croatian and Serbian subtitles.

Bigboy-thijs commented 1 year ago

Same issue here: Mibox4 (AndroidTV) Dutch subtitles available for download but not able to select .

Bigboy-thijs commented 1 year ago

The same issue with external subtitles (srt). System recognises the subtitles but while playing the movie, subtitle is not selectable.

courville commented 1 year ago

@TomiScatto please specify the language you use.

@baxax, Croatian is there but not Serbian, I am adding these language.

scatolo commented 1 year ago

@courville the language is Italian

Maurs9 commented 1 year ago

I have same issue with an Android Tv when downloading the subtitles for the movies on a external HDD. Note that the subtitles can be downloaded for the movies on a USB flash drive. But also the download subtitles from VLC works for HDD.

courville commented 1 year ago

OK thanks for the feedback. I understand now that it happens on local storage and we are hitting the Android restrictions introduced in the 'R' migration. In order to function properly nova would need android.permission.MANAGE_EXTERNAL_STORAGE (cf. https://github.com/nova-video-player/aos-AVP/issues/336). Some other players have it like vlc, mx player, etc. but nova has not been granted it yet. I will appeal again to google to see if they are more mercyful this time (cf. https://www.reddit.com/r/androiddev/comments/rmgdis/how_come_vlc_is_allowed_to_use_manage_external/). If not, I will try to figure something else.

courville commented 1 year ago

Subtitles hdd download should be fixed in next release. Note that next release will properly display subtitle track language which will help identifying subtitles tracked where subtitles are "FORCED" i.e. containing almost no subtitles (cf. https://www.rev.com/blog/subtitles-blog/what-are-forced-subtitles) which can lead to the perception that subs are not working. Moreover only subs not forced in locale language will be selected by default. In addition, I have added the possibility to download subs in all the languages supported so far by opensubtitles (there were some missing before).

pre-release available on github to test.

baxax commented 1 year ago

Subtitles hdd download should be fixed in next release. Note that next release will properly display subtitle track language which will help identifying subtitles tracked where subtitles are "FORCED" i.e. containing almost no subtitles (cf. https://www.rev.com/blog/subtitles-blog/what-are-forced-subtitles) which can lead to the perception that subs are not working. Moreover only subs not forced in locale language will be selected by default. In addition, I have added the possibility to download subs in all the languages supported so far by opensubtitles (there were some missing before).

pre-release available on github to test.

Thanks, that is a very good information! Ty a lot for your effort! :)