search

npm / fstream

Advanced FS Streaming for Node
ISC License
208 stars 43 forks source link

Follow does not get propagated to child entries of dir reader #14

Open satazor opened 11 years ago

satazor commented 11 years ago

getChildProps incorrectly sets the follow based on this.follow, shouldn't it be this.props.follow? https://github.com/isaacs/fstream/blob/master/lib/dir-reader.js#L212

follow on this or me is not being set anywhere. This causes wrong behaviour when using follow: true on nested folders that have symlinks.

AdamMagaluk commented 11 years ago

I'm seeing the same thing. Tested changing it to this.props.follow, causes it to to follow symbolic links in nested folders.

Is this the desired behavior or is it intended to not follow sym links in folders?