npm / fstream

Advanced FS Streaming for Node
ISC License
208 stars 43 forks source link

Fixed issue #14 with getChildProps setting follow. from this.follow to this.... #16

Open AdamMagaluk opened 10 years ago

AdamMagaluk commented 10 years ago

Fixes issue #14 here with not following directories that are symlinks. Not sure what the intended design was.

cbraynor commented 10 years ago

This looks like a simple typo fix, any chance this PR might get included in a v0.1.26 minor release?

dtex commented 8 years ago

Hi @zkat, I just wanted to ping on this PR. Assuming that following nested symlinks is the intended behavior, is there any reason this (once rebased) can't be merged?

dtex commented 8 years ago

Hi @zkat and @othiym23 just wanted to ping on this again. Sorry to be a squeaky wheel.

zkat commented 8 years ago

I need to write tests for this :<

dtex commented 8 years ago

HI, @othiym23 Is there anything I can do to help with this? I'd be willing to write some tests if y'all have something I can reference to see how you want them.

p.s. We met at Cascadia, I was the guy with the hexapod.

hpawe01 commented 7 years ago

Hey guys,

is there any progress regarding this PR? Need this to use symbolic links in firebase (see https://github.com/firebase/firebase-tools/issues/22).

Cheers

D1no commented 7 years ago

@zkat @othiym23 can you address this (seemingly simple) issue. Since firebase-tools depend on this library, this completely blocks any use of symlinks in firebase projects(!).

Firebase Issue: https://github.com/firebase/firebase-tools/issues/22

image

Rojuinex commented 5 years ago

I cannot believe this PR has been open for 6 years, contains a single line diff, and still hasn't been merged...

I mean, I'm all for writing tests, but guys come on. As has been mentioned firebase-tools depends upon this repo and for those of us looking to structure our code in a mono-repo we need the ability to use symlinks.

If there is anything myself or any of the community members can do to get this fixed upstream please lmk.