search

nptai / google-glog

Automatically exported from code.google.com/p/google-glog
Other
0 stars 0 forks source link

issue in demangle code #184

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?

1. Go to src\demangle.cc (line 170 - 
http://code.google.com/p/google-glog/source/browse/trunk/src/demangle.cc#170)
2. check condition: if (str == '\0') {
3. looks like it should be if (str[i] == '\0') {

There's a for loop looking for the end of the string marker but during the 
iteration, first character of the string is always checked. As a result this 
function would always return true for an non-empty string.

Original issue reported on code.google.com by DenisKra...@gmail.com on 29 Jan 2014 at 11:29

GoogleCodeExporter commented 8 years ago 
This and another pointer issue has been resolved in revision r141

Original comment by Huahang.Liu@gmail.com on 25 May 2014 at 4:12

GoogleCodeExporter commented 8 years ago 
Duplicated with Issue 175.

Original comment by Huahang.Liu@gmail.com on 25 May 2014 at 4:13