search

nptscot / osmactive

Extract active travel infrastructure from OSM
https://nptscot.github.io/osmactive/
Other
7 stars 0 forks source link

Use `osmextract::oe_get_network` #18

Closed joeytalbot closed 1 month ago

joeytalbot commented 3 months ago

Originally I was using osmextract::oe_get_network, with mode specified for either cycling or driving. I'm not sure why this was changed to osmextract::oe_get. This has removed some of the steps from osmextract::oe_get_network that filtered out inappropriate routes. For example, I've noticed that the cyclenet now includes highways that are tagged "proposed" and "construction".

construction      corridor      cycleway          path    pedestrian       primary  primary_link 
           21            14           319            69            80           356             9 
     proposed   residential     secondary       service      tertiary tertiary_link  unclassified 
            1          1980            79          2083           568             8           331

It would be best to revert to using osmextract::oe_get_network.

Robinlovelace commented 3 months ago

Reason for not using oe_get_network(): it misses The Headrow in Leeds and presumably other busways where cars cannot go: https://github.com/ropensci/osmextract/issues/289

Robinlovelace commented 3 months ago

cyclenet now includes highways that are tagged "proposed" and "construction".

construction      corridor      cycleway          path    pedestrian       primary  primary_link 
           21            14           319            69            80           356             9 
     proposed   residential     secondary       service      tertiary tertiary_link  unclassified 
            1          1980            79          2083           568             8           331

Suggested solution: add that logic around here:

https://github.com/nptscot/osmactive/blob/0449182d07b6b22138545caf579fa0762c51428b/R/osmactive.R#L81-L85

joeytalbot commented 1 month ago

The decision was to stick with osmextract::oe_get() and to remove roads tagged proposed and construction elsewhere. This is complete.