nrc-cnrc / EGSnrc

Toolkit for Monte Carlo simulation of ionizing radiation — Trousse d'outils logiciels pour la simulation Monte Carlo du rayonnement ionisant
http://nrc-cnrc.github.io/EGSnrc
GNU Affero General Public License v3.0
243 stars 146 forks source link

eV to Joules conversion in egs_chamber #475

Open MartinMartinov opened 6 years ago

MartinMartinov commented 6 years ago

I just noticed when digging around the egs_chamber code that on line 2610 (link below), the number used to for the eV to J conversion is 1.602E-10, which only has 4 significant figures, even though egs_chamber outputs dose to 5 figures. I don't think it makes any practical difference, but I think subbing in 1.60218e-10 (or maybe even using/setting up a global constant for egspp) would be a good idea.

https://github.com/nrc-cnrc/EGSnrc/blob/571bacaa537fe86ed840e969529b8783a776620b/HEN_HOUSE/user_codes/egs_chamber/egs_chamber.cpp#L2610

ftessier commented 6 years ago

Agreed!