search

nreese / kibana-time-plugin

Kibana visualization that provides controls for setting and animating time ranges.
Apache License 2.0
125 stars 55 forks source link

Fixed dependency issues for Kibana v7.0.x #55

Closed andresbrandworkz closed 5 years ago

andresbrandworkz commented 5 years ago

Modified some dependencies to make it work with Kibana v7.0.x

nreese commented 5 years ago

Thanks for getting the plugin working in 7.0. Appreciate the help.

SiwyDym commented 5 years ago

There is no typo in import in time.less? is @import (reference) "../../../src/legacy/ui/public/styles/bootstrap/mixins.less"; should be? @import (reference) "../../../src/ui/public/styles/bootstrap/mixins.less";

nreese commented 5 years ago

There is no typo in import in time.less

No. In kibana 7.0, mixins.less has been moved under /legacy https://github.com/elastic/kibana/blob/master/src/legacy/ui/public/styles/bootstrap/mixins.less

SiwyDym commented 5 years ago

Right. But on readme there is information that on master branch works also for version 6.7 which is not true ;) I have error with this import, after fix this it's works. Maybe add another branch for 6.7 version?

nreese commented 5 years ago

Looks like 6.7 does have a different import. Mind making a PR for this?

SiwyDym commented 5 years ago

Sure, i create PR

nreese commented 5 years ago

would you mind targeting this PR against 6.7 branch instead of master.