Fixing Uncaught TypeError: Cannot read property 'autoReconnect' of null (and add deps.edn)

nrepl / weasel

ClojureScript browser REPL using WebSockets

The Unlicense

324 stars 35 forks source link

Fixing Uncaught TypeError: Cannot read property 'autoReconnect' of null (and add deps.edn) #75

Open dupuchba opened 4 years ago

dupuchba commented 4 years ago

When we are trying to instantiate and goog.net.WebSocket object, it breaks with nil/null option. So I pass false when params are nil.

I also added deps.edn to make it simpler to use :git with a specific sha in deps.edn

ben-denham commented 4 years ago

I ran into the same error after upgrading some project dependencies for JDK 11 support, and the fix to WebSocket instantiation resolved the error for me. Looks like the other proposed fix should work as well, happy to test and roll another pull request for that if preferred.

bbatsov commented 3 years ago

I'm not familiar with the codebase, so I'm down with whatever people feel is best.