nrkno / sofie-timeline-state-resolver

Sofie Timeline State Resolver: A Part of the Sofie TV Studio Automation System
https://github.com/nrkno/Sofie-TV-automation/
MIT License
17 stars 20 forks source link

feat(vMix): support setting text in vMix titles #359

Open ianshade opened 2 days ago

ianshade commented 2 days ago

About the Contributor

This pull request is posted on behalf of TV 2 Norge

Type of Contribution

This is a:

Feature

Current Behavior

Text fields in Title inputs in vMix cannot be controlled by TSR.

New Behavior

Text fields in Title inputs in vMix can be controlled, using the newly added text property of TimelineContentVMixInput. They can only be addressed by the field name (a.k.a selected name), not by the index.

Testing Instructions

  1. Add a Title input
  2. Create a mapping and a timeline object similar to those in the 'supports text' test case, using field names existing in the selected title template
  3. Verify that the values for specified field names change when the timeline object starts

Other Information

Status

codecov-commenter commented 2 days ago

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Project coverage is 56.91%. Comparing base (ad41ae6) to head (65b0dcc).

Files with missing lines Patch % Lines
...state-resolver/src/integrations/vmix/connection.ts 66.66% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## release52 #359 +/- ## ============================================= + Coverage 56.86% 56.91% +0.05% ============================================= Files 131 131 Lines 10293 10308 +15 Branches 2575 2581 +6 ============================================= + Hits 5853 5867 +14 - Misses 4074 4439 +365 + Partials 366 2 -364 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ianshade commented 1 day ago

Merge conflicts were resolved