search

nrnrnr / noweb

The noweb tool for literate programming
BSD 2-Clause "Simplified" License
255 stars 27 forks source link

Duplicate file and whitespace cleanup #19

Closed turboencabulator closed 2 years ago

turboencabulator commented 2 years ago

Placing most of these type of changes into a single PR so as not to pollute other PRs.

nrnrnr commented 2 years ago

Can you please remind me what problem is being solved here?

turboencabulator commented 2 years ago

This is another part of breaking up PR #10. I've got other pieces on the way, but holding them back until this is in so I don't have merge conflicts.

nrnrnr commented 2 years ago

I reviewed the discussion on that PR, and I didn't find anything to support all these changes in whitespace. I hate to say it, but they look gratuitous. Why not simply drop this patch?

turboencabulator commented 2 years ago

I'm just trying to get some progress on the things I need from #10 since it's been sitting there for over 2 years now. The point of this PR is to fix some consistency issues that will make future PRs smaller and simpler to review, since that seemed to be the roadblock on #10.

nrnrnr commented 2 years ago

Well, I'm skeptical, but you've put more effort into this than I have, and I don't see that the patch does real harm. So I'll merge it.