nsat / pypredict

Spire port of predict open-source tracking library
GNU General Public License v2.0
64 stars 17 forks source link

test: Fix format of QTH testing data in test.py #30

Closed Echelon9 closed 6 years ago

Echelon9 commented 6 years ago

Must consist of exactly three elements: (lat(N), long(W), alt(m))

Echelon9 commented 6 years ago

For the avoidance of doubt, the internal PREDICT C code handles four line QTH's read from a user's $HOME directory, where the first line is assumed to be a station's descriptive name. This first text line is stripped off before the geographic location is processed.

However, the Python API assumes a QTH comprising a three-datapoint geographic location is provided.

So let's just provide the format the Python API expects.

jtrutna commented 6 years ago

Gets us closer to working tests.

vagrant@vagrant-ubuntu-trusty-64:~/pypredict$ sudo python setup.py install
running install
running build
running build_py
running build_ext
running install_lib
running install_egg_info
Removing /usr/local/lib/python2.7/dist-packages/pypredict-1.2.egg-info
Writing /usr/local/lib/python2.7/dist-packages/pypredict-1.2.egg-info
vagrant@vagrant-ubuntu-trusty-64:~/pypredict$ ./test.py 
test_transits_are_truncated_if_the_overlap_the_start_or_end_times (__main__.TestPredict) ... ERROR

======================================================================
ERROR: test_transits_are_truncated_if_the_overlap_the_start_or_end_times (__main__.TestPredict)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./test.py", line 32, in test_transits_are_truncated_if_the_overlap_the_start_or_end_times
    next_transit = next(predict.transits(tle, qth, ending_after=at))
  File "/home/vagrant/pypredict/predict.py", line 51, in transits
    transit = quick_predict(tle, ts, qth)
PredictException: time Wed 14Jan15 02:27:36 too far from present

----------------------------------------------------------------------
Ran 1 test in 0.000s

FAILED (errors=1)
vagrant@vagrant-ubuntu-trusty-64:~/pypredict$ 

Merged!

Unfortunately, the test suite is pretty grossly insufficient even if it did work and the tests in our internal harness aren't ready to be exported yet. :/

Still, thanks for the PR!