Base staleness check on TLE Epoch instead of wall clock

nsat / pypredict

Spire port of predict open-source tracking library

GNU General Public License v2.0

64 stars 17 forks source link

Base staleness check on TLE Epoch instead of wall clock #46

Closed miketwo closed 5 months ago

miketwo commented 2 years ago

Fixes #45

The staleness check within predict.c was based on being within a year of the current time. We change it so that it has to be within a year of the Epoch date on the TLE.

nick-pascucci-spire commented 2 years ago

Hi, thanks for your pull request! This looks like it will be a helpful fix.

Before I merge your PR I'd like to make sure it's tested. Would you mind adding some test cases demonstrating the desired behavior and edge cases?

jerematt commented 5 months ago

Merged as part of #63 with unit tests added and included in release 1.7.2.

Thanks again for the Issue/PR @miketwo