nstbayless / CV1-controls

Improved Controls ROMhack for Castlevania 1
6 stars 1 forks source link

Buggy with UC since v2.6 #2

Open ImJezze opened 4 years ago

ImJezze commented 4 years ago

I just tested the most recent patch and it seems the patches have some issues with the hack Ultimate Castlevania since version 2.6.

  1. You can land on invisible stairs and climb them out of the screen. grafik grafik

  2. You can destroy invisible blocks, which spawn enemies as collectable item. grafik grafik

I used Lunar IPS for patching and Mesen as emulator.

cv1-controls-catch-vcancel - v2.6 and up to v3.0 have this issue cv1-controls-uc-catch-vcancel - v2.5 and down to v1.1 work fine

nstbayless commented 4 years ago

The intention is to use the "hack" version, which can be found in the folder for compatability with other hacks. That is, cv1-controls-hack-catch-vcancel.ips.

This version of the patch is compatible with a variety of hacks. However, other people have also overlooked it. Perhaps it's too hidden, or too poorly named.

How can I make it easier for people to find that version of the patch?

Edit: perhaps it may be possible to combine the "hack" and standard versions into a single cross-compatible hack. This would definitely fix the problem. It will take some R&D, however.

ImJezze commented 4 years ago

Oh, this is a bit embarrassing for me... 😅

I think I used the normal version because the first hack that is mentioned in the readme was Ultimate Castlevania and it was not separately listed in the "Compatability with other hacks" section again.

How can I make it easier for people to find that version of the patch?

Maybe you can move the patch instruction into another file named "howtopatch" and make a simple bullet-point list for each patch variant and its supported hacks.

pleasejustgo commented 3 years ago

Hi, I love improved controls. It's adds much needed QOL in Castelvania. Inertia is f*cken great. Thanks for that. However....

I just tried to apply improved controls to Ultimate Castlevania and it, in fact, does not work. I made sure to use the correct "hack" version. The game will not load. I just get a black screen. Maybe it could be the emulator/core. I'm using OpenEmu, nestopia core. But as it stands now, I can't get this to work with Ultimate at all... At first I did use the base rom version and got the same invisible stairs bugs but then after re-reading the readme file I realized it was supposed to be the "hack" version which brings me to my next point.

The way you organize the folders could be clearer. Maybe the base rom version could be in a "base rom" folder one level down from the main folder. Same with reborn and Holy relics. Then have another folder, one level down from main folder as well, that's for "other hacks".

Also, someone on romhacking.net mentioned in a review that it's it's possible to make Simon appear at the bottom of the same screen when jumping onto stairs going up. Sometimes it won't load the next screen. Tested, no problems in Holy Relics.

Thanks for this, hope to see an update!

nstbayless commented 3 years ago

@pleasejustgo I just tried running the improved controls hack with Ultimate Castlevania, it works fine and I see none of the bugs described. Can you verify that your ROM patched with only Ultimate Castlevania (and not the improved controls) has file sha1 hash 8CDAE6284056949DF993F8AD35C9105CCB7305B6 (or ROM sha1 hash A3982C0881E55920928E8B8AA42577E60E54F5B0)?

I have updated the folder configuration, now the root directory of the hack contains:

- cv-reborn/
- the-holy-relics/
- other-hacks/
- standard/

and standard is the one to use for a vanilla ROM, other-hacks to use in combination with other hacks such as ultimate castlevania.