search

nstlaurent / DoomLauncher

Doom Launcher is a doom launching utility and database for custom wads and pk3s
GNU General Public License v3.0
233 stars 20 forks source link

Some tests always fail when building on non-US locale #230

Closed ALDamico closed 3 years ago

ALDamico commented 3 years ago

The tests that rely in parsing of dates and/or floating-point numbers will fail when building DoomLauncher on a computer running a non-English Windows locale.

One such test method is, for example, TestSyncUpdate(), which contains a call to DateTime.Parse(string). In order to fix the issues, the DateTime.Parse(string, IFormatProvider) should be called instead.

ALDamico commented 3 years ago

Created PR #231 to fix this issue.

ALDamico commented 3 years ago

Merged into development. Closing.