search

nt1m / livemarks

Extension that restores RSS Feed Livemarks in Firefox.
https://addons.mozilla.org/firefox/addon/livemarks/
MIT License
231 stars 23 forks source link

orange icon in standard dark theme #420

Open mare1203 opened 2 years ago

mare1203 commented 2 years ago

Add-on version Add-on version: 3.5

Describe the bug I would like to be able to set the orange color of the icon in the firefox dark theme as well

screenshot_1

nt1m commented 1 year ago

This actually seems like a Firefox bug, not a bug from this extension. Firefox seems to force a filter on extension icons in dark mode. https://searchfox.org/mozilla-central/rev/99a9eed20cf195b8ff815604876b6fb73ca5ecd7/browser/themes/shared/urlbar-searchbar.css#360-380

@robwu @emilio Can we remove this? This extension has a setting to configure the extension icon color, and it's not getting honored.

nt1m commented 1 year ago

I meant to ping @Rob--W here :)

emilio commented 1 year ago

Yeah, +1 on removing this, but it's at least blocked on a container extension release so https://github.com/mozilla/multi-account-containers/pull/2584 and so is picked up...

Rob--W commented 1 year ago

Emilio, do we need to block on that update? If an extension has explicitly declared a separate dark theme icon, then I would expect that icon to be used in unmodified form.