nteract / commuter

🚎 Notebook sharing hub
BSD 3-Clause "New" or "Revised" License
495 stars 66 forks source link

Unable to launch commuter #249

Closed maytronics-ben closed 5 years ago

maytronics-ben commented 5 years ago

I am trying to set up commuter to work with an s3 storage backend on an Amazon EC2 instance.

Referencing the documentation at https://github.com/nteract/commuter I have set the relevant environment variables with the following commands:

export COMMUTER_STORAGE_BACKEND=s3
export COMMUTER_BUCKET=bucket-name

But when trying to launch commuter via commuter command I get the following error:

CONFIGURED DISCOVERY none
Running in the current working directory,  /home/jupyter-tljh_admin
internal/modules/cjs/loader.js:583
    throw err;
    ^

Error: Cannot find module './config/babel.flow.config'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:581:15)
    at Function.Module._load (internal/modules/cjs/loader.js:507:25)
    at Module.require (internal/modules/cjs/loader.js:637:17)
    at require (internal/modules/cjs/helpers.js:22:18)
    at Object.<anonymous> (/usr/local/share/.config/yarn/global/node_modules/@nteract/webpack-configurator/index.js:12:25)
    at Module._compile (internal/modules/cjs/loader.js:689:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
    at Module.load (internal/modules/cjs/loader.js:599:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:538:12)
    at Function.Module._load (internal/modules/cjs/loader.js:530:3)

Would love to get this set up, is this a reasonable place to ask for this sort of help? Thanks,

erolosty commented 5 years ago

@rgbkrk Is this still the right repo to track issues against?

I also couldn't run, after doing an npm install as suggested by the docs.

@aquazure I could get it to start if I clone master, maybe thats what you'll need to do for now too

erolosty commented 5 years ago

@aquazure yours may be a dupe of: https://github.com/nteract/commuter/issues/247

maytronics-ben commented 5 years ago

@erolosty

Retried with:

npm install https://github.com/nteract/commuter.git
yarn add https://github.com/nteract/commuter.git

As well as cloning master branch into local directory and running commuter command

I still get thrown the same error, however...

rgbkrk commented 5 years ago

Super sorry! This is the right repo. We've been going through some structural changes with the nteract repos so I didn't get this one back to a normal state. On my end I've been focused on an internal fork of commuter (at Netflix) and want to get the changes to be minimal on both while getting prod mode back to working for the deployed version externally.

I've sadly not been running with the commuter command, instead using either yarn dev or yarn start (after assets have been built). Does that work for you on master for the moment?

erolosty commented 5 years ago

Hey, don't worry! We all have day jobs, that tend to not focus around supporting random folk from the interwebs :)

I managed to get it to start with:

npm run start

This gets me into a state in which the bottom half of each page (directory tree and notebooks) takes a full screen's worth of space and simply says:

An unexpected error has occurred.

in the center of the page.

If there is some way to turn up the verbosity of logging, I'd be happy to try it out. My guess (given that this is the issue, that started me down the path to building it myself, when the version in npm broke) is that the cause of the error message is the same as: https://github.com/nteract/commuter/issues/248

But I don't have anything in the logs that proves it

erolosty commented 5 years ago

ping /feelsbad

romeran commented 5 years ago

Guess it's the same issue as here? @rgbkrk any news?

rgbkrk commented 5 years ago

I just migrated all the issues for commuter over to this repo and will start handling an overhaul of commuter with a few other folks. My most recent relevant update is from https://github.com/nteract/commuter/issues/249#issuecomment-456947550:

Super sorry! This is the right repo. We've been going through some structural changes with the nteract repos so I didn't get this one back to a normal state. On my end I've been focused on an internal fork of commuter (at Netflix) and want to get the changes to be minimal on both while getting prod mode back to working for the deployed version externally.

I've sadly not been running with the commuter command, instead using either yarn dev or yarn start (after assets have been built). Does that work for you on master for the moment?

SelinGungor commented 5 years ago

Is this Issue fixed? I am getting the error below, after installing babel manually npm install -g babel-cli:

`SyntaxError: backend/config.js: Unexpected token, expected , (3:22) 1 | // @flow 2 |

3 | function deprecate(env: Object, oldVar: string, newVar: string) { | ^ 4 | if (env[oldVar]) { 5 | console.warn(${oldVar} is deprecated, please use ${newVar}); 6 | } `

rgbkrk commented 5 years ago

It's not fixed and not ready for consumption currently. We're doing some internal fixups and will be posting a refreshed commuter soon.

Curiosity -- will you be backing notebooks with local storage or S3?

taniki commented 5 years ago

I managed to run it with pm2. There is a weird react error but nothing critical. I am using it with s3 over s3fs because commuter doesn't seem to support s3 custom endpoint yet (same for papermill).

SelinGungor commented 5 years ago

Local storage @rgbkrk.

erolosty commented 5 years ago

Local Storage

weldpua2008 commented 5 years ago

@taniki Can you share how you run it?

# export COMMUTER_STORAGE_BACKEND=s3
# export COMMUTER_BUCKET=my-special-bucket-name
# /usr/local/nodejs-binary-8.15.0/bin/pm2 start commuter
[PM2] Starting /usr/bin/commuter in fork_mode (1 instance)
[PM2] Done.
┌──────────┬────┬─────────┬──────┬───────┬────────┬─────────┬────────┬─────┬───────────┬──────┬──────────┐
│ App name │ id │ version │ mode │ pid   │ status │ restart │ uptime │ cpu │ mem       │ user │ watching │
├──────────┼────┼─────────┼──────┼───────┼────────┼─────────┼────────┼─────┼───────────┼──────┼──────────┤
│ commuter │ 0  │ N/A     │ fork │ 13273 │ online │ 0       │ 0s     │ 0%  │ 15.1 MB   │ root │ disabled │
└──────────┴────┴─────────┴──────┴───────┴────────┴─────────┴────────┴─────┴───────────┴──────┴──────────┘
# /usr/local/nodejs-binary-8.15.0/bin/pm2 logs commuter 
/root/.pm2/logs/commuter-error.log last 15 lines:
0|commuter |     at Object.Module._extensions..js (module.js:664:10)
0|commuter |     at Module.load (module.js:566:32)
0|commuter |     at tryModuleLoad (module.js:506:12)
0|commuter |     at Function.Module._load (module.js:498:3) code: 'MODULE_NOT_FOUND' }
0|commuter | { Error: Cannot find module './config/babel.flow.config'
0|commuter |     at Function.Module._resolveFilename (module.js:548:15)
0|commuter |     at Function.Module._load (module.js:475:25)
0|commuter |     at Module.require (module.js:597:17)
0|commuter |     at require (internal/module.js:11:18)
0|commuter |     at Object.<anonymous> (/usr/lib/node_modules/@nteract/commuter/node_modules/@nteract/webpack-configurator/index.js:12:25)
0|commuter |     at Module._compile (module.js:653:30)
0|commuter |     at Object.Module._extensions..js (module.js:664:10)
0|commuter |     at Module.load (module.js:566:32)
0|commuter |     at tryModuleLoad (module.js:506:12)
0|commuter |     at Function.Module._load (module.js:498:3) code: 'MODULE_NOT_FOUND' }
taniki commented 5 years ago

@weldpua2008

ecosystem.config.js

module.exports = {
  apps : [{
    name: 'commuter',
    script: 'lib/index.js',

    instances: 1,
    autorestart: true,
    watch: true,
    max_memory_restart: '1G',
    env: {
      NODE_ENV: 'development'
    },
    env_production: {
      NODE_ENV: 'production',

      COMMUTER_STORAGE_BACKEND: 'local',
      COMMUTER_PORT: '80',
      COMMUTER_LOCAL_STORAGE_BASEDIRECTORY: "/root/notebooks/"
    }
  }]
};

and

$ pm2 [start/restart] ecosystem.config.js --env production
weldpua2008 commented 5 years ago

@taniki thank you for your quick response.

I tried the solution but it fails in the same way:

0|commuter  | { Error: Cannot find module './config/babel.flow.config'
0|commuter  |     at Function.Module._resolveFilename (module.js:548:15)
0|commuter  |     at Function.Module._load (module.js:475:25)
0|commuter  |     at Module.require (module.js:597:17)
0|commuter  |     at require (internal/module.js:11:18)
0|commuter  |     at Object.<anonymous> (/usr/local/nodejs-binary-8.15.0/lib/node_modules/@nteract/commuter/node_modules/@nteract/webpack-configurator/index.js:12:25)
0|commuter  |     at Module._compile (module.js:653:30)
0|commuter  |     at Object.Module._extensions..js (module.js:664:10)
0|commuter  |     at Module.load (module.js:566:32)
0|commuter  |     at tryModuleLoad (module.js:506:12)
0|commuter  |     at Function.Module._load (module.js:498:3)
0|commuter  |     at Module.require (module.js:597:17)
0|commuter  |     at require (internal/module.js:11:18)
0|commuter  |     at Object.<anonymous> (/usr/local/nodejs-binary-8.15.0/lib/node_modules/@nteract/commuter/next.config.js:1:84)
0|commuter  |     at Module._compile (module.js:653:30)
0|commuter  |     at Object.Module._extensions..js (module.js:664:10)
0|commuter  |     at Module.load (module.js:566:32) code: 'MODULE_NOT_FOUND' }

Maybe the path /usr/local/nodejs-binary-8.15.0/lib/node_modules/@nteract/commuter/lib/index.js is wrong?

# cat ecosystem.config.js 
module.exports = {
  apps : [{
    name: 'commuter',
script: '/usr/local/nodejs-binary-8.15.0/lib/node_modules/@nteract/commuter/lib/index.js',
    instances: 1,
    autorestart: true,
    watch: true,
    max_memory_restart: '1G',
    env: {
      NODE_ENV: 'development'
    },
    env_production: {
      NODE_ENV: 'production',

      COMMUTER_STORAGE_BACKEND: 'local',
      COMMUTER_PORT: '80',
      COMMUTER_LOCAL_STORAGE_BASEDIRECTORY: "/root/notebooks/"
    }
  }]
};
taniki commented 5 years ago

@weldpua2008 you should try with current master branch instead of npm package. That what I am doing.

romeran commented 5 years ago

Hi @rgbkrk, any news?

captainsafia commented 5 years ago

Hello folks!

I was able to reproduce this on my local machine in commuter v.5.7.0. I've publish a new minor version of commuter (5.8.0) that resolves this issue on my machine. Upgrading to this new minor version should resolve this issue.